-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multimodal UX - Audio Component #1112
Open
nking-1
wants to merge
29
commits into
main
Choose a base branch
from
multimodal-surfaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing import error catch in environment detection.
Moved exceptions catch into one line.
Not yet implemented, but available to call within notebooks.
Primitives were duplicating code.
Audio/image/video now have API primitives to generate from model.
Very basic but enough for rendering.
Also added sample audio/video assets (both creative commons).
This is important as we're using kernel comms (JSON) behind the scenes.
Clean-up of previous commit.
Important for package testing.
Console prints, frontend controls need to be added later.
There are some large formatting changes to existing code from using the "Svelte for VS Code" extension. It seems like that's actually using Prettier under the hood. Sam and I chatted about this and will move forward with using it as our default formatter so hopefully the formatting changes won't happen again. |
Connected from API primitives to client.
…guidance into multimodal-surfaces
Forgot to commit this for previous.
…guidance into multimodal-surfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an audio component for the Jupyter widget.
audio()
guidance function to the Jupyter widget.