Skip to content

Commit

Permalink
build: ➖ Do not officially support Python 3.8 anymore (#114)
Browse files Browse the repository at this point in the history
[Python 3.8 is EOL since October 2024](https://peps.python.org/pep-0569/)
and some depdendencies have already dropped support for it.

BREAKING_CHANGE: Now requires requires `httpx >= 0.23.0`

Lower versions of `httpx` do not work with Python 3.13+ helps to keep
project file simpler. Dropping support for Python 3.8 leads to a
breaking change anyway, so it is a good time to make this change.
  • Loading branch information
zoido authored Jan 22, 2025
1 parent 2a8f8ea commit 5a6972e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 17 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pypi-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up Python 3.8
- name: Set up Python 3.9
uses: actions/setup-python@v5
with:
python-version: "3.8"
python-version: "3.9"

- name: Install pypa/build
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]

steps:
- uses: actions/checkout@v4
Expand Down
17 changes: 4 additions & 13 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,15 @@ classifiers = [
"Topic :: Utilities",
]
dependencies = [
"httpx>=0.16 ; python_version < '3.13'" ,
"httpx>=0.23 ; python_version >= '3.13'" ,
"httpx>=0.23",
"tomli >= 1.1.0 ; python_version < '3.11'",
]
description = 'H2O Cloud Discovery Python CLient'
keywords = []
license = "Apache-2.0"
name = "h2o-cloud-discovery"
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
version = "2.2.1"

[project.urls]
Expand All @@ -40,17 +39,10 @@ packages = ["src/h2o_discovery"]

[[tool.hatch.envs.test.matrix]]
httpx = ["httpx0.23", "httpx0.24", "httpx0.25", "httpx0.26", "httpx0.27", "httpx0.28"]
python = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]

[[tool.hatch.envs.test.matrix]]
httpx = ["httpx0.16", "httpx0.21", "httpx0.22"]
python = ["3.8", "3.9", "3.10", "3.11", "3.12"]
python = ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]

[tool.hatch.envs.test.overrides]
matrix.httpx.dependencies = [
{value = "httpx==0.16.*", if = ["httpx0.16"]},
{value = "httpx==0.21.*", if = ["httpx0.21"]},
{value = "httpx==0.22.*", if = ["httpx0.22"]},
{value = "httpx==0.23.*", if = ["httpx0.23"]},
{value = "httpx==0.24.*", if = ["httpx0.24"]},
{value = "httpx==0.25.*", if = ["httpx0.25"]},
Expand All @@ -61,8 +53,7 @@ matrix.httpx.dependencies = [

[tool.hatch.envs.test]
dependencies = [
"pytest-asyncio==0.24.0 ; python_version < '3.9'",
"pytest-asyncio==0.25.1 ;python_version >= '3.9'",
"pytest-asyncio==0.25.1",
"pytest==8.3",
"respx>=0.16",
]
Expand Down

0 comments on commit 5a6972e

Please sign in to comment.