feat: ✨ Discover registered links when available #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoido
force-pushed
the
lp/links-model-client
branch
from
3961d9b to
212d18f
Compare
- add links map to the discovery model - load links when the discover is called As Links are new addtion to the API, we do not fail when server returns 404 and only have no links available. All this to have backward compatibility. RESOLVES h2oai/cloud-discovery#694
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Links are new addtion to the API, we do not fail when server returns 404 and only have no links available. All this to have backward compatibility.
RESOLVES https://github.com/h2oai/cloud-discovery/issues/694