-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make conda package support multiple python versions #2227 #2247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marek-mihok! We probably want to sync publish conda step in release-wave
with publish-conda
job as well.
@mturoci what is it used for? Is it for cases when you want to publish conda without going through all release process? It has no runs yet. ![]() Also is |
Yes.
Probably not. Seems like a leftover, but better check.
They should be the same. No matter which workflow I use, I want the output to be identical. |
@mturoci synced. Can we try to run |
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.The problem was that the package only supports the version of python it was built in. It can be solved by specifying
noarch: python
insidemeta.yaml
conda config file. The result is the single platform independent package supporting multiple python versions.Also update of the pipeline build action (
amauryval/publish_conda_package_action
) to version 2.0.3 is necessary, because it allows specifyingnoarch
value as thePlatforms
parameter.Closes #2227