Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for alternative texts from img and input type=image #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added support for alternative texts from img and input type=image #34

wants to merge 5 commits into from

Conversation

King2500
Copy link

Solves #5

Supports texts from img and input[type=image] alt-attributes.

Included a test case.
All tests ran locally without errors.

@King2500 King2500 changed the title Added support for alternativ texts from img and input type=image Added support for alternative texts from img and input type=image Jul 15, 2016
dominykas
dominykas reviewed Jul 17, 2016
View reviewed changes
src/utils.js
if (element.getAttribute('alt')) {
alternatives += element.getAttribute('alt');
}
return alternatives;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just return it, with || ''?

@dominykas
Copy link
Member

Thanks, this is awesome!

I'll go try to revive my work on upgrading to latest nodes, which I forgot all about :)

@dominykas
Copy link
Member

If you update with master, the modern nodes will be used on Travis. Might still get a failure on saucelabs, but we can try to deal with it if it does happen.

@dominykas dominykas mentioned this pull request Aug 5, 2016
Closed
@King2500
Copy link
Author

Done so far.

@King2500
Copy link
Author

ping @dominykas

Any time for review?

@dominykas
Copy link
Member

Sorry, important deadlineand holidays got in the way. Will get back to normal life next week.

@King2500
Copy link
Author

@dominykas
How you're doing?
Just a reminder ;-)

@dominykas dominykas mentioned this pull request Dec 20, 2016
Closed
@King2500
Copy link
Author

@dominykas
Do you have any time for reviewing this? It's been almost a year since my pull-request.
Thanks!

@King2500
Copy link
Author

King2500 commented Nov 7, 2017

Is this project still maintained?

Anything I can help to get this released...?

@King2500
Copy link
Author

@dominykas Any chance for release of this fix? Or do you see any issue with this?

traynor added a commit to traynor/h5o-js that referenced this pull request May 24, 2020
@traynor
see PR: Added support for alternative texts from img and input type=i…
781fc1f 
…mage h5o#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@King2500 @dominykas