Add Dacia Spring Support #459

f3dora19 · 2022-01-03T10:54:39Z

Add Dacia Spring Support
Add Charge Pause/Resume endpoint
Add fixtures
Add tests

f3dora19 · 2022-01-03T11:08:11Z

Hello everybody,

I made some changes on the api to be able to pause/resume dacia spring charge, but on the MyDacia application the only endpoint available to start the charge was totally different as the renault endpoint.
So I have to make some changes, and the only way I have to make the difference between one endpoint or another was the brand label "RENAULT" vs "DACIA".

epenet · 2022-01-03T11:16:44Z

I don't think using the brand label is the best way to differentiate between available endpoints.
I think we should be using either the model code (XBG1VE) or the carGateway ("GDC" on Zoe40 / "AVN" on Zoe50 and Twingo)

epenet · 2022-01-03T11:23:42Z

Also, in order to make it easier to review, could you please make at least two separate PRs?

One PR for the new fixtures and corresponding minor adjustments.
And a separate PR for the new charge-pause-resume endpoint.

f3dora19 · 2022-01-03T11:55:50Z

I don't think using the brand label is the best way to differentiate between available endpoints. I think we should be using either the model code (XBG1VE) or the carGateway ("GDC" on Zoe40 / "AVN" on Zoe50 and Twingo)

Ok, differentiation is now pointing to the model code.

But I do not understand the carGateway attribute, I don't find it in any code except for the duster fixtures, can you tell me more about it ?

epenet · 2022-01-03T12:40:59Z

See #404 for carGateway. It is still work in progress...

epenet · 2022-01-05T09:32:30Z

You should be able to run pre-commit run --all-files to fix the format issues.

f3dora19 · 2022-01-05T09:57:32Z

@epenet, yes, you've right I runned nox --session=pre-commit, but there was a conflicts with my git pre-commit hook.

Just to inform you, I work on separate PRs like asked !

f3dora19 · 2022-01-05T10:37:29Z

@epenet, this PR is rebased on #460 PR, please ensure that PR #460 be merged before, and you will review this one with the only new charge-pause-resume features.

* Add Dacia Spring charge pause/resume endpoint * Add tests

epenet

Now that #480 is merged, you should be able to access the carGateway property of the car adapter.

I suggest that you add a fixture for the carGateway of your dacia...

epenet · 2022-01-28T07:14:51Z

src/renault_api/cli/charge/control.py

+    await vehicle.get_details()
+    if (
+        vehicle._vehicle_details
+        and vehicle._vehicle_details.get_model_code() == "XBG1VE"
+    ):


Since the carGateway cannot be uses (it shows AVN also for the dacia spring), I suggest this:

Suggested change

await vehicle.get_details()

if (

vehicle._vehicle_details

and vehicle._vehicle_details.get_model_code() == "XBG1VE"

):

details = await vehicle.get_details()

if details.get_model_code() == "XBG1VE":

src/renault_api/cli/charge/control.py

epenet · 2022-01-28T07:18:45Z

@afaucogney added the gateway details, and it seems that the dacia spring uses the same AVN gateway as the recent renault vehicles so I don't think we can use the carGateway to distinguish.

epenet · 2022-01-28T07:29:03Z

Also, I have thought more about it and I think that you should move the logic to the VEHICLE_SPECIFICATIONS (in kamereon\model.py), something like this:

VEHICLE_SPECIFICATIONS: Dict[str, Dict[str, Any]] = {
    ...
    "XBG1VE": {  # Dacia Spring
        "charging-start-via-kcm": True,
    },
}

Then in KamereonVehicleDetails you can add a method uses_endpoint_via_kcm:

    def uses_endpoint_via_kcm(self, endpoint: str) -> bool:
        """Return True if model uses endpoint via kcm."""
        # Default to False for unknown vehicles
        if self.model and self.model.code:
            return VEHICLE_SPECIFICATIONS.get(self.model.code, {}).get(
                f"{endpoint}-via-kcm", True
            )
        return False  # pragma: no cover

* Modify tests * Modify Kamereon model Signed-off-by: Luc Viala <[email protected]>

epenet · 2022-01-29T09:35:22Z

There are some conflicts that need resolving.
I think also that you shouldn't create a new method on the RenaultVehicle class.
You should move the logic for kcm out of the CLI and into the RenaultVehicle class which should have a start and a stop method.

f3dora19 · 2022-01-30T09:07:19Z

Hey @epenet, it will be very helpful if I can get a carGateway for the Spring, it could resolve lot of issues I get.
How can we determine which model uses a gateway ?

epenet · 2022-01-30T19:18:13Z

To get the car gateway, you need to run this command:
renault-api --json http get "/commerce/v1/accounts/{account_id}/kamereon/kca/car-adapter/v1/cars/{vin}"

epenet · 2022-01-30T20:25:38Z

src/renault_api/cli/charge/control.py

+    details = await vehicle.get_details()
+    if details.get_model_code() == "XBG1VE":
+        response = await vehicle.set_charge_pause_resume("resume")
+    else:
+        response = await vehicle.set_charge_start()


I think it is better to keep the original method (simply set_charge_start) and move the logic there.

Suggested change

details = await vehicle.get_details()

if details.get_model_code() == "XBG1VE":

response = await vehicle.set_charge_pause_resume("resume")

else:

response = await vehicle.set_charge_start()

response = await vehicle.set_charge_start()

epenet · 2022-01-30T20:27:21Z

src/renault_api/cli/charge/control.py

+    details = await vehicle.get_details()
+    if details.get_model_code() == "XBG1VE":
+        response = await vehicle.set_charge_pause_resume("pause")
+        click.echo(response.raw_data)
+    else:
+        response = None
+        click.echo("Function unavailable")
+        exit(1)


I think it is better to simply create a new function against the vehicle, and make the check there (you can raise NotImplementedException for the other vehicles)

Suggested change

details = await vehicle.get_details()

if details.get_model_code() == "XBG1VE":

response = await vehicle.set_charge_pause_resume("pause")

click.echo(response.raw_data)

else:

response = None

click.echo("Function unavailable")

exit(1)

response = await vehicle.set_charge_stop()

click.echo(response.raw_data)

epenet · 2022-01-30T20:29:58Z

src/renault_api/kamereon/models.py

+            return VEHICLE_SPECIFICATIONS.get(self.model.code, {}).get(
+                f"{endpoint}-via-kcm", False
+            )
+        return False  # pragma: no cover


I think you are adding tests for this, so no need to exclude coverage:

Suggested change

return False # pragma: no cover

return False

epenet · 2022-01-30T20:39:25Z

src/renault_api/kamereon/__init__.py

@@ -311,17 +320,28 @@ async def set_vehicle_action(
    vin: str,
    endpoint: str,
    attributes: Dict[str, Any],
+    actions: str = "actions",


If you add an argument in the middle of the list, it becomes a breaking change.
You have to add it at the bottom of the list to make it non-breaking (even with a default value).

I suggest:

attributes: Dict[str, Any], endpoint_version: Optional[int] = None, data_type: Optional[Dict[str, Any]] = None, *, car_adapter_type: str = "kca" actions: str = "actions",

epenet · 2022-01-30T20:41:00Z

src/renault_api/kamereon/__init__.py

    car_adapter_url = get_car_adapter_url(
        root_url=root_url,
        account_id=account_id,
        version=endpoint_version or _get_endpoint_version(ACTION_ENDPOINTS[endpoint]),
        vin=vin,
    )
-    url = f"{car_adapter_url}/actions/{endpoint}"
+
+    if actions == "charge":


I think it would be better to use a separate (new) argument to decide on the car_adapter_url:

if car_adapter_type == "kcm": car_adapter_url = get_kcm_car_adapter_url(... else: car_adapter_url = get_car_adapter_url(...

epenet · 2022-01-30T20:48:25Z

src/renault_api/renault_vehicle.py

+    async def set_charge_pause_resume(
+        self, action: str
+    ) -> models.KamereonVehicleChargingStartActionData:


Please rename to set_charge_stop. Then inside the function you check if uses_endpoint_via_kcm, and send the correct request (pause or raise NotImplemented).

Suggested change

async def set_charge_pause_resume(

self, action: str

) -> models.KamereonVehicleChargingStartActionData:

async def set_charge_stop(self) -> models.KamereonVehicleChargingStartActionData:

You can do the same in set_charge_start, which should check if uses_endpoint_via_kcm, and send the correct request (kca start, or kcm resume).

epenet · 2022-02-01T09:07:59Z

Hi @lucviala
I have created and merged #500 which was partially based on your work, and implements the base functionnality for Renault.
Can you please rebase this branch on top of it?

jumpjack · 2022-04-28T08:59:52Z

To get the car gateway, you need to run this command:
renault-api --json http get "/commerce/v1/accounts/{account_id}/kamereon/kca/car-adapter/v1/cars/{vin}"

Is this command correct? I get this with both my Renault vehicles and using both accounts (SFDC and MYRENAULT):

C:\>renault-api --json http get "/commerce/v1/accounts/xxxxxxxxxxxxxxxxxxxxx/kamereon/kca/car-adapter/v1/cars/VF1xxxxxxxxxxxxxxxx"

Error: ('err.func.404', '{"timestamp":"2022-04-28T08:54:18.320+0000","status":404,"error":"Not Found","message":"No message available","path":"/car-adapter/v1/cars/VF1xxxxxxxxxxxxxxxx"}')

f3dora19 force-pushed the feat/dacia-spring-support branch from e888e30 to 15caeeb Compare January 3, 2022 10:56

f3dora19 force-pushed the feat/dacia-spring-support branch from 9f60fa0 to 3c11575 Compare January 5, 2022 09:54

f3dora19 force-pushed the feat/dacia-spring-support branch from 3c11575 to 6cad42d Compare January 5, 2022 10:33

Add Dacia Spring Support

3eeb09e

* Add Dacia Spring charge pause/resume endpoint * Add tests

f3dora19 force-pushed the feat/dacia-spring-support branch from 6cad42d to 3eeb09e Compare January 5, 2022 11:58

epenet reviewed Jan 27, 2022

View reviewed changes

This was referenced Jan 27, 2022

JSON option not working? #467

Closed

Api Coverage for Dacia Spring #488

Open

Add specific method for kcm endpoint

7eae9a1

* Modify tests * Modify Kamereon model Signed-off-by: Luc Viala <[email protected]>

epenet reviewed Jan 30, 2022

View reviewed changes

epenet added the enhancement New feature or request label Feb 1, 2022

This was referenced Feb 1, 2022

Fix check for energy type in CLI #496

Merged

Add support for Dacia Spring charge control #502

Merged

epenet closed this Feb 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Dacia Spring Support #459

Add Dacia Spring Support #459

f3dora19 commented Jan 3, 2022

f3dora19 commented Jan 3, 2022

epenet commented Jan 3, 2022

epenet commented Jan 3, 2022

f3dora19 commented Jan 3, 2022

epenet commented Jan 3, 2022

epenet commented Jan 5, 2022

f3dora19 commented Jan 5, 2022 •

edited

Loading

f3dora19 commented Jan 5, 2022 •

edited

Loading

epenet left a comment

This comment was marked as outdated.

epenet Jan 28, 2022

epenet commented Jan 28, 2022

epenet commented Jan 28, 2022 •

edited

Loading

epenet commented Jan 29, 2022

f3dora19 commented Jan 30, 2022 •

edited

Loading

epenet commented Jan 30, 2022

epenet Jan 30, 2022

epenet Jan 30, 2022

epenet Jan 30, 2022

epenet Jan 30, 2022

epenet Jan 30, 2022

epenet Jan 30, 2022

epenet commented Feb 1, 2022

jumpjack commented Apr 28, 2022

Add Dacia Spring Support #459

Add Dacia Spring Support #459

Conversation

f3dora19 commented Jan 3, 2022

f3dora19 commented Jan 3, 2022

epenet commented Jan 3, 2022

epenet commented Jan 3, 2022

f3dora19 commented Jan 3, 2022

epenet commented Jan 3, 2022

epenet commented Jan 5, 2022

f3dora19 commented Jan 5, 2022 • edited Loading

f3dora19 commented Jan 5, 2022 • edited Loading

epenet left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

epenet Jan 28, 2022

Choose a reason for hiding this comment

epenet commented Jan 28, 2022

epenet commented Jan 28, 2022 • edited Loading

epenet commented Jan 29, 2022

f3dora19 commented Jan 30, 2022 • edited Loading

epenet commented Jan 30, 2022

epenet Jan 30, 2022

Choose a reason for hiding this comment

epenet Jan 30, 2022

Choose a reason for hiding this comment

epenet Jan 30, 2022

Choose a reason for hiding this comment

epenet Jan 30, 2022

Choose a reason for hiding this comment

epenet Jan 30, 2022

Choose a reason for hiding this comment

epenet Jan 30, 2022

Choose a reason for hiding this comment

epenet commented Feb 1, 2022

jumpjack commented Apr 28, 2022

f3dora19 commented Jan 5, 2022 •

edited

Loading

f3dora19 commented Jan 5, 2022 •

edited

Loading

epenet commented Jan 28, 2022 •

edited

Loading

f3dora19 commented Jan 30, 2022 •

edited

Loading