Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Design for Tree Table Completed #30

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

tomaseuu
Copy link
Collaborator

Developer: Thomas Le

Closes #15

Pull Request Summary

This pull request is to update the design to match the Figma layout. For now, I’ve just implemented the table section and left out the popup on the right side of the page. I tried to stick as closely as possible to the design, making a few small adjustments to keep it simple and looking good.

Modifications

treeTable\page.tsx

  • Implemented the table layout and pagination based on the Figma design.
  • Added navbar and functionality for linking "Tree Inventory" selection.

treeTable\treetable.css

  • Styled the table, buttons, and page controls for a clean and simple look.
  • Applied custom styles for buttons and table header.

Testing Considerations

I have only tested it with the original navbar, the one with just the word "Navbar". I would recommend testing it with the current Navbar.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

image

@tomaseuu tomaseuu linked an issue Feb 13, 2025 that may be closed by this pull request
@kaseyliu
Copy link
Collaborator

This looks great! Could you add functionality for these buttons as well? You can make it so that the numbers navigate to the correct section in the data, and you can add a bit more dummy data if needed. It would also be great if when the user is on the first page, the "Previous" button is not clickable, and when they are on the last page, the "Next" button is not clickable. Let me know if you have any questions or need help!
Screenshot 2025-02-19 at 1 53 40 PM

@elhagen13 elhagen13 removed the on hold label Mar 5, 2025
@elhagen13
Copy link
Collaborator

Looks good! Thanks for getting it in before midpoint demos!

@elhagen13 elhagen13 merged commit 03502c3 into develop Mar 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Design for Tree Table
3 participants