Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected POI Page Component, Key Stats Component #34

Closed
wants to merge 0 commits into from

Conversation

carboninl
Copy link
Collaborator

@carboninl carboninl commented Feb 4, 2025

Developer: Nick Carboni, Saurish Suman

Closes #15, #16

Pull Request Summary

Completed the Selected POI Page Component, which includes a Key Stats sub component. The main component takes in an image link, name, # of tours completed and # of total tours, and a content/description that is formatted and displayed.

Modifications

  • Created components/Selected_POI_Page.tsx to contain the main component structure
  • Created components/Key_Stats.tsx to contain the sub component structure, which is then used in the above component
  • CSS Styling files for each of the above components

Testing Considerations

We have tested the component visually. Future tests should probably ensure different image sizes are displayed properly. Additionally while we tested multiple common phone resolutions, this area could looked into more.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

image

Copy link
Collaborator

@emily-yarvis emily-yarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this once the build runs on my end but I would love it if you guys could pull the CSS out into a seperate file so its a bit cleaner as a follow up! Let me know if you have any questions at all about that. Otherwise Really great job this looks awesome!

Copy link
Collaborator

@emily-yarvis emily-yarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm after deploying on my side its definitely looking a bit funky and doesn't seem to match the image you guys attached in the CR.
Screenshot 2025-02-05 224458

@emily-yarvis
Copy link
Collaborator

emily-yarvis commented Feb 6, 2025

Awesome looking much better with the image.
one nit comment is that in the image you attached in the CR looks like there some more Lorem Ipsum text in the description and I think it would be great to bring more of that back so it looks a bit cleaner for demoing.

Also when I deployed the newest changes the text color looked different then in the image you guys attached and make it pretty hard to read. I kind of remember talking about this but hoping you guys can look into a fix for this before we put it out!

Screenshot 2025-02-05 232025

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lcslo-kco ❌ Failed (Inspect) Feb 17, 2025 7:21pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Point of Interest (Selected POI Page) Component
2 participants