Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreatePOIComponent #39

Merged
merged 1 commit into from
Feb 10, 2025
Merged

CreatePOIComponent #39

merged 1 commit into from
Feb 10, 2025

Conversation

EthanSunjoonYang
Copy link
Collaborator

@EthanSunjoonYang EthanSunjoonYang commented Feb 10, 2025

Developer: {Ethan Yang}

Closes #{14}

Pull Request Summary

Added frontend POI card component.

Modifications

Created Point of Interest (List-View) file

Testing Considerations

Tested the component on localhost (screenshots attached of final product)

Pull Request Checklist

  • [✅] Code is neat, readable, and works
  • [✅] Comments are appropriate
  • [✅] The commit messages follows our guidelines
  • [✅] The developer name is specified
  • [✅] The summary is completed
  • [✅] Assign reviewers

Screenshots/Screencast

Screenshot 2025-02-09 at 9 47 50 PM

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lcslo-kco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 5:45am

Copy link
Collaborator

@emily-yarvis emily-yarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm going to merge this for now since I just want to get some more components into the UI but it would be incredible if as a small follow up task you could extract the css into a seperate file. But we can talk more about this tomorrow.

@emily-yarvis emily-yarvis merged commit e71c100 into develop Feb 10, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants