Fixing save state bug among other things #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly this changes adjusts the functionality of the progress bar such that when you complete one POI you dont nessacarily complete the POI's before it since they are NOT in order. Additionally I adjusted the selected poi component to take in the current progress rather then being hard coded to an order.
Currently when you click on a POI and then return to the list view page, your progress is reset to zero. This change fixes that by saving the stat of your progress within your session. Saving within yur session
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gracebw7
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Emily Yarvis
Closes #53, #51, #48
Pull Request Summary
The main thing this change does is fix the save state bug as well as ensure that when you click on a poi card you are routed to the corresponding selected poi component. Additionally this change renames and reorganizes some files for clarity. But most importantly it saves a users current progress within each session so you can click between pages and your progress will still be saved as long as you are in the correct session.
Modifications
Testing Considerations
npm run dev
Pull Request Checklist