Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create audio controls component #61

Merged
merged 5 commits into from
Mar 4, 2025

Conversation

EthanSunjoonYang
Copy link
Collaborator

Developer: Ethan Yang

Closes #13

Pull Request Summary

Completed Audio Controls component

Modifications

Created AudioControls.tsx and AudioControls.css files

Testing Considerations

Tested component in localhost

Pull Request Checklist

  • [✅]Code is neat, readable, and works
  • [✅] Comments are appropriate
  • [✅] The commit messages follows our guidelines
  • [✅] The developer name is specified
  • [✅] The summary is completed
  • [✅] Assign reviewers

Screenshots/Screencast

Screenshot 2025-03-02 at 9 13 43 PM

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lcslo-kco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 3:02am

@emily-yarvis
Copy link
Collaborator

This looks great! But could you please rebase your changes with mainline? Let me know if you need any help doing this but it looks like you don't have the most recent changes specifically with files changing locations which will make your pull break a lot of the code.

@emily-yarvis
Copy link
Collaborator

Also when you click the play/pause button the pause is the correct grey color but the play icon is a much lighter and less visible color (especially in dark mode).

@emily-yarvis emily-yarvis merged commit ca28e86 into develop Mar 4, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Audio Controls Component
2 participants