Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

52 dynamically render pois #64

Merged
merged 2 commits into from
Mar 4, 2025
Merged

52 dynamically render pois #64

merged 2 commits into from
Mar 4, 2025

Conversation

carboninl
Copy link
Collaborator

Developer: Nick Carboni

Closes #52

Pull Request Summary

  • removed hard-coded POI data
  • implemented dynamically rendered POI card list by calling api/poi
  • additionally calls api/audiofile to fetch duration info, which is merged into poi data
  • modifications to sessionStorage to support the above changes

Modifications

  • components/poiList.tsx: all changes are contained within this file, mostly within a new useEffect function for fetching and storing data

Testing Considerations

  • audiofiles name must be identical to the pois name in order for duration info to be properly merged/displayed. Incorrect name matching will result in the display of a fallback duration of "0:00"

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

image

carboninl added 2 commits March 3, 2025 01:05
@carboninl
feat: dynamically render POIs list by calling the api/poi endpoint. F…
de26a97 
…ixed progress bar to avoid division by zero errors while data is still loading in. Fixed POI interface to properly match the Mongo schema.
@carboninl
feat: using api/audiofile endpoint, fetch duration info and merge it …
2db9fa8 
…with POI data to display duration on the POI cards
@carboninl carboninl self-assigned this Mar 4, 2025
@carboninl carboninl linked an issue Mar 4, 2025 that may be closed by this pull request
Dynamically Render POIs #52
Closed
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lcslo-kco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 5:01am

@gracebw7 gracebw7 merged commit ed8467a into develop Mar 4, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracebw7 gracebw7 gracebw7 approved these changes

@emily-yarvis emily-yarvis Awaiting requested review from emily-yarvis

Assignees

@carboninl carboninl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamically Render POIs
2 participants
@carboninl @gracebw7