Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added presigned url get routes for s3 document upload and download #59

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

KevinBeltran23
Copy link
Contributor

Developer: Kevin Beltran

Closes #48

Pull Request Summary

Created presigned url GET routes for file upload and download using S3

Modifications

I created a route.ts under api/download-url and api/upload-url
I also creates an aws-s3.ts file under lib

Testing Considerations

Double check it works

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Copy link
Collaborator

@aarav27 aarav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this through POSTMAN with a sample image and it works, well done! The only thing to add is the standard responses inside src/lib/response.ts.

@KevinBeltran23
Copy link
Contributor Author

Did it. Let me know if anything still looks off. Thanks!

Copy link
Collaborator

@aarav27 aarav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM!

@aarav27 aarav27 merged commit 55b7d20 into develop Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Presigned URL Routes
2 participants