Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Referral Database Page #20

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

karthik0605
Copy link
Collaborator

Developer: Karthik Balaji

Closes #16

Pull Request Summary

Created the referral database page in the database folder, which enables easy search and sorting for all the user data (using MUI). For now it is just dummy data, but it will eventually be retrieved from the database.

Also created a short dev doc (will be expanded in the future): https://docs.google.com/document/d/1f_TKgDrwvLuwABVExWTHTUTb8_lcF2FpJz_D_Qa5fWA/edit?usp=sharing

Modifications

  • In src/database folder created a folder called "referrals" with two files
    - page.tsx for displaying the referral page
    - ReferralDataGrid.tsx to handle the grid logic

Testing Considerations

  • Page loads data
  • You are able to search, sort, filter, and export to a CSV anything in the table

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Screenshot 2025-02-10 at 12 37 22 AM Screenshot 2025-02-10 at 12 37 30 AM

@karthik0605 karthik0605 requested a review from IvanA673 February 10, 2025 08:55
@karthik0605 karthik0605 linked an issue Feb 10, 2025 that may be closed by this pull request
11 tasks
Copy link
Collaborator

@IvanA673 IvanA673 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very impressed that you finished this task on short notice. Thank you for getting this task finished up! You did a great job. A few things I saw when I went to review:

  • You created the component under the database folder. All components should be built within the components folder. Also, follow naming conventions which for components should be camel case.
  • When you create a component, along with it create a module.css file which is where all styling should be implemented. No styling was required for this issue but creating one will prepare devs for when it is to be styled
  • The actual page should be made using Next.js app router which basically means you need to create a folder in the app folder and make a page.tsx in it. This allows us to navigate to that page by just modifying our URL.

I've made those changes which you could see for yourself. If you have any questions please let me know. Thanks!

@IvanA673 IvanA673 merged commit b156648 into develop Feb 10, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Referral Database Page
2 participants