Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Branches #858

Merged
merged 10 commits into from
Dec 29, 2024
Merged

Update Branches #858

merged 10 commits into from
Dec 29, 2024

Conversation

KRSHH
Copy link
Collaborator

@KRSHH KRSHH commented Dec 29, 2024

Summary by Sourcery

Add mouth masking and DirectML execution provider support. Fix typo in README.

New Features:

  • Added a mouth masking feature controlled by the --mouth-mask argument.

Tests:

  • Added a new execution provider for DirectML.

Copy link
Contributor

sourcery-ai bot commented Dec 29, 2024

Reviewer's Guide by Sourcery

This pull request introduces a mouth masking feature, adds execution provider DirectML, and fixes a typo in the README.

Class diagram showing updated program arguments structure

classDiagram
    class ProgramArguments {
        +bool mouth_mask
        +bool many_faces
        +bool nsfw_filter
        +bool map_faces
        +string video_encoder
        +int video_quality
        +bool live_mirror
        +parse_args()
    }
    note for ProgramArguments "Added new mouth_mask argument"
Loading

File-Level Changes

Change Details Files
Added a mouth masking feature that allows users to mask the mouth region of the target face.
  • Added a --mouth-mask command-line argument to enable mouth masking.
  • Documented the --mouth-mask option in the README file.
  • Updated the argument parsing logic to handle the new argument.
  • Added the implementation of the mouth masking feature in the core module.
modules/core.py
README.md
Added execution provider DirectML.
  • Created a new batch file run-directml.bat to run the program with DirectML execution provider.
run-directml.bat
Fixed a typo in the README file.
  • Corrected "that's we" to "that's why" in the "Press" section.
README.md
Removed unnecessary files.
  • Removed run-laptop-gpu.bat and run_with_chocolatey.bat files.
run-laptop-gpu.bat
run_with_chocolatey.bat
Updated the Features section in the README file.
  • Added " - Everything is realtime" to the Features section title.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@KRSHH KRSHH merged commit aed933c into premain Dec 29, 2024
3 checks passed
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KRSHH - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR description mentions adding DirectML execution provider support, but the implementation appears to be missing from the diff. Please include the DirectML provider implementation code.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -217,7 +218,7 @@ Looking for a CLI mode? Using the -s/--source argument will make the run program


## Press
**We are always open to criticism and ready to improve, that's we didn't cherrypick anything.**
**We are always open to criticism and ready to improve, that's why we didn't cherrypick anything.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Typo: "cherrypick" should be "cherry-pick"

Suggested change
**We are always open to criticism and ready to improve, that's why we didn't cherrypick anything.**
**We are always open to criticism and ready to improve, that's why we didn't cherry-pick anything.**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants