-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Branches #858
Update Branches #858
Conversation
Make main up to date with premain branch
Added the --mouth-mask argument to the CLI
Reviewer's Guide by SourceryThis pull request introduces a mouth masking feature, adds execution provider DirectML, and fixes a typo in the README. Class diagram showing updated program arguments structureclassDiagram
class ProgramArguments {
+bool mouth_mask
+bool many_faces
+bool nsfw_filter
+bool map_faces
+string video_encoder
+int video_quality
+bool live_mirror
+parse_args()
}
note for ProgramArguments "Added new mouth_mask argument"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KRSHH - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR description mentions adding DirectML execution provider support, but the implementation appears to be missing from the diff. Please include the DirectML provider implementation code.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -217,7 +218,7 @@ Looking for a CLI mode? Using the -s/--source argument will make the run program | |||
|
|||
|
|||
## Press | |||
**We are always open to criticism and ready to improve, that's we didn't cherrypick anything.** | |||
**We are always open to criticism and ready to improve, that's why we didn't cherrypick anything.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Typo: "cherrypick" should be "cherry-pick"
**We are always open to criticism and ready to improve, that's why we didn't cherrypick anything.** | |
**We are always open to criticism and ready to improve, that's why we didn't cherry-pick anything.** |
Summary by Sourcery
Add mouth masking and DirectML execution provider support. Fix typo in README.
New Features:
--mouth-mask
argument.Tests: