Wip;

hans-thomas · Jan 20, 2025 · 11fef3f · 11fef3f
1 parent be6e7cd
commit 11fef3f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/src/Commands/Exception.php b/src/Commands/Exception.php
@@ -53,11 +53,7 @@ public function handle(): int
             if ($compactName === '' || filled($compactName) || $this->confirm('Should create a compact exception?')) {
                 $compactName = $compactName ?: $this->ask('What should be its name?');
                 if (blank($compactName)) {
-                    if (version_compare(app()->version(), '11', '>=')) {
-                        $this->fail('The name of the compact exception can not be empty.');
-                    } elseif (version_compare(app()->version(), '10', '>=')) {
                         throw new \Exception('The name of the compact exception can not be empty.');
-                    }
                 }
             }
             if ($compactName) {

diff --git a/src/Commands/Relation.php b/src/Commands/Relation.php
@@ -101,11 +101,7 @@ class_basename(MorphToRequest::class),
                     HasManyRequest::class,
                 ])
             ) {
-                if (version_compare(app()->version(), '11', '>=')) {
-                    $this->fail('The {related-name} parameter should not be empty when going to create a many-to-many relationship.');
-                } elseif (version_compare(app()->version(), '10', '>=')) {
                     throw new \Exception('The {related-name} parameter should not be empty when going to create a many-to-many relationship.');
-                }
             }
 
             if (in_array(

diff --git a/tests/Feature/Commands/ExceptionTest.php b/tests/Feature/Commands/ExceptionTest.php
@@ -159,6 +159,8 @@ public function compactFormExceptionWithoutParamWithEmptyCompactName(): void
         self::assertFileDoesNotExist($fullException);
         self::assertFileDoesNotExist($compactException);
 
+        $this->expectExceptionMessage('The name of the compact exception can not be empty.');
+
         $this->artisan('valravn:exception blog posts BPEcx')
             ->expectsConfirmation('Should create a compact exception?', 'yes')
             ->expectsQuestion('What should be its name?', '')

diff --git a/tests/Feature/Commands/RelationTest.php b/tests/Feature/Commands/RelationTest.php
@@ -191,6 +191,8 @@ public function belongsToManyWithoutRelatedName(): void
 
         self::assertFileDoesNotExist($file);
 
+        $this->expectExceptionMessage('The {related-name} parameter should not be empty when going to create a many-to-many relationship.');
+
         $this->artisan('valravn:relation blog Post core --belongs-to-many')
              ->assertFailed();