fix: list loop and auto scroll in AppAutoComplete #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icoxxx
requested review from
SvetBorislavov,
yiliev0 and
a team
as code owners
jbair06
requested changes
Jan 30, 2025
|
@jbair06 what do you think |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 157 157
Lines 5891 5891
Branches 1085 1085
=======================================
Hits 5836 5836
Misses 52 52
Partials 3 3 |
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
icoxxx
force-pushed
the
1467-navigation-issues-with-the-account-chooser
branch
from
adefad7 to
0dd67f2
Compare
jbair06
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix for dropdown in AppAutoComplete (now it loops and handles auto scrolling properly).
PS: Looping is not removed but rather fixed (bug in the code), can remove it if it is necessary.
This PR includes the changes requested in #1427
Related issue(s):
#1467