Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create the v059x node-override.yaml via solo #1192

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: create the v059x node-override.yaml via solo #1192

wants to merge 25 commits into from
+143 −38

Conversation

instamenta
Copy link
Contributor

Description

Adds new class NetworkOverridesModel which creates the network-override.yaml inside the staging directory and then copies it inside the nodes during node setup

Related Issues

@instamenta instamenta self-assigned this Jan 21, 2025
@instamenta instamenta requested review from leninmehedy and a team as code owners January 21, 2025 14:08
@instamenta instamenta linked an issue Jan 21, 2025 that may be closed by this pull request
create the v0.59.x node-override.yml via Solo #1151
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Unit Test Results - Linux

  1 files  ±0   60 suites  ±0   2s ⏱️ -1s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1f53f30. ± Comparison against base commit c50f4c3.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   60 suites  ±0   7s ⏱️ -4s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1f53f30. ± Comparison against base commit c50f4c3.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon requested a review from a team as a code owner January 21, 2025 18:20
@jeromy-cannon jeromy-cannon added the PR: Checks Failed A pull request where the checks have failed. label Jan 23, 2025
instamenta and others added 6 commits January 23, 2025 17:04
@instamenta
merge with main and ran npm i
74d1c16 
Signed-off-by: instamenta <[email protected]>
@instamenta
Merge remote-tracking branch 'origin/main' into 01151-create-the-v059…
401ebac 
…x-network-overrideyml-via-solo
@instamenta
Merge remote-tracking branch 'origin/main' into 01151-create-the-v059…
91329f1 
…x-network-overrideyml-via-solo
@jeromy-cannon
Merge branch 'main' into 01151-create-the-v059x-network-overrideyml-v…
03f86ba 
…ia-solo

Signed-off-by: Jeromy Cannon <[email protected]>
@instamenta
switch to new structure for the NetworkOverridesModel.toYaml() method…
0dccc4d 
… to convert the interfaceBindings and endpointOverrides to JSON and to emit them as keys if they are not needed

Signed-off-by: instamenta <[email protected]>
@instamenta
add functionality to turn json string inside the node overrides to js…
d4511e6 
…on notation

Signed-off-by: instamenta <[email protected]>
@jeromy-cannon jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Jan 31, 2025
@instamenta
Merge remote-tracking branch 'origin/main' into 01151-create-the-v059…
bef5aa0 
…x-network-overrideyml-via-solo

# Conflicts:
#	src/core/genesis_network_models/genesis_network_data_constructor.ts
@instamenta
swith all calls to the setupNetworkNode method to true on the isGenes…
ff069c8 
…is parameter

Signed-off-by: instamenta <[email protected]>
@instamenta instamenta removed the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Feb 3, 2025
@instamenta instamenta changed the title feat: create the v059x network-override.yaml via solo feat: create the v059x node-override.yaml via solo Feb 3, 2025
jeromy-cannon
jeromy-cannon reviewed Feb 4, 2025
View reviewed changes
src/core/genesis_network_models/genesis_network_data_constructor.ts Outdated
@@ -31,9 +31,17 @@ export class GenesisNetworkDataConstructor implements ToJSON {
) {
nodeAliases.forEach(nodeAlias => {
const genesisPrivateKey = PrivateKey.fromStringED25519(constants.GENESIS_KEY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not provided by the user then we generate one and then store it in k8s secrets, but DO NOT set it to GENESIS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the logic create new key and save to k8 if no one is available

JeffreyDallas and others added 9 commits February 5, 2025 10:46
@JeffreyDallas
Merge commit '04b616e16ee224772ac5a1d181d814713400984d' into 01151-cr…
8fc07f5 
…eate-the-v059x-network-overrideyml-via-solo

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/node/tasks.ts
#	src/core/platform_installer.ts
@JeffreyDallas @jeromy-cannon
Update src/commands/node/handlers.ts
fab250b 
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
@JeffreyDallas @jeromy-cannon
Update src/commands/node/handlers.ts
444614a 
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
@JeffreyDallas @jeromy-cannon
Update src/commands/node/handlers.ts
f87b07c 
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: JeffreyDallas <[email protected]>
@JeffreyDallas
add constant
f1035e9 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
generate new key if not found
218eddf 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
fix constructor
badbaaf 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
save
8a6bfbf 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
Merge branch 'main' into 01151-create-the-v059x-network-overrideyml-v…
1f53f30 
…ia-solo
@JeffreyDallas
Copy link
Contributor

Many test failed because could not reach Active status
with the following errors in swirds.log

java.net.BindException: Cannot assign requested address
        at java.base/sun.nio.ch.Net.bind0(Native Method) ~[?:?]
        at java.base/sun.nio.ch.Net.bind(Net.java:565) ~[?:?]
        at java.base/sun.nio.ch.Net.bind(Net.java:554) ~[?:?]
        at java.base/sun.nio.ch.NioSocketImpl.bind(NioSocketImpl.java:636) ~[?:?]
        at java.base/java.net.ServerSocket.bind(ServerSocket.java:391) ~[?:?]
        at java.base/java.net.ServerSocket.bind(ServerSocket.java:342) ~[?:?]
        at com.swirlds.platform.network.connectivity.SocketFactory.configureAndBind(SocketFactory.java:90) ~[swirlds-platform-core-0.59.0-main.x5322bdc.jar:0.59.0-main.x5322bdc]
        at com.swirlds.platform.network.connectivity.TlsFactory.createServerSocket(TlsFactory.java:118) ~[swirlds-platform-core-0.59.0-main.x5322bdc.jar:0.59.0-main.x5322bdc]
        at com.swirlds.platform.network.connectivity.ConnectionServer.run(ConnectionServer.java:72) ~[swirlds-platform-core-0.59.0-main.x5322bdc.jar:0.59.0-main.x5322bdc]
        at com.swirlds.common.threading.framework.internal.StoppableThreadImpl.doWork(StoppableThreadImpl.java:614) ~[swirlds-common-0.59.0-main.x5322bdc.jar:0.59.0-main.x5322bdc]
        at com.swirlds.common.threading.framework.internal.StoppableThreadImpl.run(StoppableThreadImpl.java:215) ~[swirlds-common-0.59.0-main.x5322bdc.jar:0.59.0-main.x5322bdc]
        at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon left review comments

@JeffreyDallas JeffreyDallas JeffreyDallas left review comments

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@instamenta instamenta

Labels
PR: Checks Failed A pull request where the checks have failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create the v0.59.x node-override.yml via Solo
3 participants
@instamenta @JeffreyDallas @jeromy-cannon