Update Vagrant tutorial get started links to new collection #2676
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im2nguyen
requested review from
danielehc and
eganhashicorp
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Relates to: https://github.com/hashicorp/tutorials/pull/2437 (this PR is a dependency) |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
BrianMMcClain
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
I just want to verify the comment on the other PR that this should be merged before the tutorials PR. I might have an incorrect mental modal, but my understand was:
- Remove the links to the to-be deleted tutorials from dev-portal (Temp remove GS content from Vagrant to update Vagrant GS #2677)
- Add the new tutorials (https://github.com/hashicorp/tutorials/pull/2437)
- Add links to the new tutorials on dev-portal (Update Vagrant tutorial get started links to new collection #2676)
Either way, this PR LGTM!
…portal into vagrant-get-started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
🤷 Why
🛠️ How
📸 Design Screenshots
🧪 Testing
💭 Anything else?