Apply Hlint suggestions (#354)

.hlint.yaml

@@ -11,7 +11,6 @@
 - ignore: {name: "Use camelCase"}
 - ignore: {name: "Redundant $"}
 - ignore: {name: "Redundant bracket"}
-- ignore: {name: "Functor law"}
 - ignore: {name: "Use catMaybes"}
 - ignore: {name: "Use <$>"}
 - ignore: {name: "Eta reduce"}

src/HIE/Bios/Config.hs

@@ -1,10 +1,7 @@
 {-# LANGUAGE NamedFieldPuns #-}
 {-# LANGUAGE OverloadedStrings #-}
-{-# LANGUAGE TupleSections #-}
 {-# LANGUAGE DeriveFunctor #-}
 {-# LANGUAGE PatternSynonyms #-}
-{-# LANGUAGE ViewPatterns #-}
-{-# LANGUAGE LambdaCase #-}
 -- | Logic and datatypes for parsing @hie.yaml@ files.
 module HIE.Bios.Config(
     readConfig,

src/HIE/Bios/Cradle.hs

@@ -1,5 +1,4 @@
 {-# LANGUAGE BangPatterns #-}
-{-# LANGUAGE LambdaCase #-}
 {-# LANGUAGE OverloadedStrings #-}
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE TupleSections #-}

src/HIE/Bios/Types.hs

@@ -1,12 +1,6 @@
 {-# LANGUAGE CPP #-}
 {-# LANGUAGE FlexibleInstances #-}
 {-# LANGUAGE ScopedTypeVariables #-}
-{-# LANGUAGE DeriveFunctor #-}
-{-# LANGUAGE DeriveTraversable #-}
-{-# LANGUAGE DeriveFoldable #-}
-{-# OPTIONS_GHC -Wno-orphans #-}
-
-{-# LANGUAGE DeriveFoldable #-}
 {-# LANGUAGE DeriveTraversable #-}
 module HIE.Bios.Types where
 
@@ -54,7 +48,7 @@ data ActionName a
   | Other a
   deriving (Show, Eq, Ord, Functor)
 
-data Log = 
+data Log =
   LogAny String
   | LogProcessOutput String
   deriving Show
@@ -148,7 +142,7 @@ instance Fail.MonadFail m => Fail.MonadFail (CradleLoadResultT m) where
 #endif
 
 instance MonadTrans CradleLoadResultT where
-    lift = CradleLoadResultT . liftM CradleSuccess
+    lift = CradleLoadResultT . fmap CradleSuccess
     {-# INLINE lift #-}
 
 instance (MonadIO m) => MonadIO (CradleLoadResultT m) where