-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of not loaded files for cabal #453
Conversation
The basic idea is that we can include new files to be loaded along with old files into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have a couple of comments and improvements, but otherwise I think this is good to go!
.../projects/failing-multi-repl-cabal-project/multi-repl-cabal-fail/multi-repl-cabal-fail.cabal
Outdated
Show resolved
Hide resolved
.../projects/failing-multi-repl-cabal-project/multi-repl-cabal-fail/multi-repl-cabal-fail.cabal
Show resolved
Hide resolved
tests/projects/failing-multi-repl-cabal-project/multi-repl-cabal-fail/src/Fail.hs
Outdated
Show resolved
Hide resolved
tests/projects/failing-multi-repl-cabal-project/multi-repl-cabal-fail/src/Lib.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: fendor <[email protected]>
…al-fail/app/Main.hs Co-authored-by: fendor <[email protected]>
…al-fail/multi-repl-cabal-fail.cabal Co-authored-by: fendor <[email protected]>
Co-authored-by: fendor <[email protected]>
Co-authored-by: fendor <[email protected]>
cc @fendor , I've addressed the comments, please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! One nitpick comment, once you have decided whether you agree or not, you should be able to press the merge button :)
Co-authored-by: fendor <[email protected]>
The main use case:$X$ , we know exctaly what files $Y$ we actually did try to load. Where $Y \in X$ .
When we fail to load some files
We need this to reduce the number of files we put into senquential loading loop once batch load is failed for haskell/haskell-language-server#4445
TODO:
But I don't know how to trigger such loading errors.