[1.3.0] Add Missing Tests [API-1112] (#703)

* add missing tests

* add http client tests

* try enabling TestClient_AddDistributedObjectListener

* exclude unused codec files from test coverage

* exclude unused codec files from test coverage

* refactor test structs for field alignment check

* test http client retry mechanism

* fix bad merge

* address review comments

* refactor index variables "ind" to "i"

* field reordering for "fieldalignment"

* undo wrong file remove

aggregate/aggregate_test.go

@@ -0,0 +1,88 @@
+package aggregate
+
+import (
+	"fmt"
+	"testing"
+)
+
+func TestMakeString(t *testing.T) {
+	tcs := []struct {
+		name     string
+		attrPath string
+		want     string
+	}{
+		{
+			name:     "test",
+			attrPath: "attribute",
+			want:     "test(attribute)",
+		},
+		{
+			name:     "",
+			attrPath: "",
+			want:     "()",
+		},
+	}
+	for i, tt := range tcs {
+		t.Run(fmt.Sprintf("makeString case: %d", i), func(t *testing.T) {
+			if got := makeString(tt.name, tt.attrPath); got != tt.want {
+				t.Errorf("makeString() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func TestAggStringer(t *testing.T) {
+	tcs := []struct {
+		aggInstance fmt.Stringer
+		want        string
+	}{
+		{
+			aggInstance: Count("attribute"),
+			want:        "Count(attribute)",
+		},
+		{
+			aggInstance: DistinctValues("attribute"),
+			want:        "DistinctValues(attribute)",
+		},
+		{
+			aggInstance: DoubleSum("attribute"),
+			want:        "DoubleSum(attribute)",
+		},
+		{
+			aggInstance: DoubleAverage("attribute"),
+			want:        "DoubleAverage(attribute)",
+		},
+		{
+			aggInstance: IntSum("attribute"),
+			want:        "IntSum(attribute)",
+		},
+		{
+			aggInstance: IntAverage("attribute"),
+			want:        "IntAverage(attribute)",
+		},
+		{
+			aggInstance: LongSum("attribute"),
+			want:        "LongSum(attribute)",
+		},
+		{
+			aggInstance: LongAverage("attribute"),
+			want:        "LongAverage(attribute)",
+		},
+		{
+			aggInstance: Max("attribute"),
+			want:        "Max(attribute)",
+		},
+
+		{
+			aggInstance: Min("attribute"),
+			want:        "Min(attribute)",
+		},
+	}
+	for i, tt := range tcs {
+		t.Run(fmt.Sprintf("makeString case: %d", i), func(t *testing.T) {
+			if got := tt.aggInstance.String(); got != tt.want {
+				t.Errorf("String() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

internal/invocation/stripe_executor_test.go

@@ -53,7 +53,7 @@ func Test_defaultExecFn(t *testing.T) {
 }
 
 func TestStripeExecutor_dispatch(t *testing.T) {
-	tests := []struct {
+	tcs := []struct {
 		queueCount    int
 		key           int
 		expectedIndex int
@@ -84,7 +84,7 @@ func TestStripeExecutor_dispatch(t *testing.T) {
 			expectedIndex: 0,
 		},
 	}
-	for i, tt := range tests {
+	for i, tt := range tcs {
 		t.Run(fmt.Sprintf("QueueCount: %d, Key: %d", tt.queueCount, tt.key), func(t *testing.T) {
 			se := newStripeExecutorWithConfig(tt.queueCount, 10_000)
 			task := func() {

internal/proto/codec/error_holder_codec.go

@@ -24,12 +24,6 @@ const (
 	ErrorHolderCodecErrorCodeInitialFrameSize = ErrorHolderCodecErrorCodeFieldOffset + proto.IntSizeInBytes
 )
 
-/*
-type errorholderCodec struct {}
-
-var ErrorHolderCodec errorholderCodec
-*/
-
 func EncodeErrorHolder(clientMessage *proto.ClientMessage, errorHolder proto.ErrorHolder) {
 	clientMessage.AddFrame(proto.BeginFrame.Copy())
 	initialFrame := proto.NewFrame(make([]byte, ErrorHolderCodecErrorCodeInitialFrameSize))