Use Hazelcast 5.5.0 #170
Closed
Use Hazelcast 5.5.0 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldziedziul
previously approved these changes
Dec 9, 2024
JamesHazelcast
previously approved these changes
Dec 18, 2024
…r confs, cleanups
…the issue that session MAY indeed not be propagated
ldziedziul
reviewed
Jan 14, 2025
| @@ -382,6 +382,18 @@ | |||
| <artifactId>httpclient</artifactId> | |||
| <version>${httpclient.version}</version> | |||
| <scope>test</scope> | |||
| <exclusions> | |||
There was a problem hiding this comment.
Why exclusions? Maybe left a comment?
src/test/java/com/hazelcast/wm/test/jetty/WebFilterBasicTest.java
Outdated
Show resolved
Hide resolved
| assertEquals("value", executeRequest("read", serverPort2, cookieStore)); | ||
| } | ||
|
|
||
| @Test(timeout = 20000) | ||
| @Test | ||
| @RetryingTest(5) |
| @@ -31,7 +31,7 @@ | |||
| </init-param> | |||
| <init-param> | |||
| <param-name>sticky-session</param-name> | |||
| <param-value>false</param-value> | |||
| <param-value>true</param-value> | |||
.officialRun/Template JUnit.run.xml
Outdated
…itigate the issue that session MAY indeed not be propagated" This reverts commit 60d843f.
|
verify |
1 similar comment
|
verify |
|
Just for the record (we spoke with Łukasz on Slack): those latest commits were just test changes, I was trying to localize the reason for some test failures. I will re-request review once I get the test to be stable. |
Co-authored-by: Łukasz Dziedziul <[email protected]>
|
verify |
TomaszGaweda
dismissed stale reviews from ldziedziul and JamesHazelcast
Was for old version
TomaszGaweda
force-pushed
the
TomaszGaweda-patch-1
branch
from
49ba7eb to
883e236
Compare
# Conflicts: # pom.xml
…zGaweda-patch-1 # Conflicts: # pom.xml
Test Results 15 files 15 suites 24m 51s ⏱️ Results for commit 77ff7c1. ♻️ This comment has been updated with latest results. |
TomaszGaweda
force-pushed
the
TomaszGaweda-patch-1
branch
from
ac93215 to
cd3c19b
Compare
TomaszGaweda
force-pushed
the
TomaszGaweda-patch-1
branch
from
796687a to
77ff7c1
Compare
TomaszGaweda
commented
Feb 14, 2025
| <option name="MAIN_CLASS_NAME" value="" /> | ||
| <option name="METHOD_NAME" value="" /> | ||
| <option name="TEST_OBJECT" value="class" /> | ||
| <option name="VM_PARAMETERS" value="-ea -Djava.net.preferIPv4Stack=true" /> |
There was a problem hiding this comment.
Added because we want to use java.net.preferIPv4Stack always
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.