Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECR module updated to v2.x #54

Merged
merged 1 commit into from
Jan 24, 2025
Merged

ECR module updated to v2.x #54

merged 1 commit into from
Jan 24, 2025

Conversation

kobrikx
Copy link
Contributor

@kobrikx kobrikx commented Jan 17, 2025 •
edited
Loading

What's new:

  • ECR module updated to the latest version(v2.x)

Testing done:

Deploy with ECR v1.x:
Screenshot 2025-01-17 at 13 10 01

Module updated to ECR v2.x (plan):
Screenshot 2025-01-17 at 13 13 39

Teraform Apply (ECR v2.x):
Screenshot 2025-01-17 at 14 02 23

@kobrikx kobrikx requested a review from AutomationD January 17, 2025 00:54
@AutomationD
Copy link
Contributor

Are there any changes when doing this upgrade? I'd suggest doing a test like this:

  1. Deploy with previous ECR
  2. Update ECR
  3. Plan & confirm what kinds of changes are there. Ideally there should be none.

@kobrikx kobrikx removed the request for review from AutomationD January 17, 2025 11:06
@kobrikx kobrikx merged commit 0767641 into main Jan 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobrikx @AutomationD