Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concretize Files.Glob documentation #1664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Concretize Files.Glob documentation #1664

wants to merge 1 commit into from

Conversation

andrask
Copy link

@andrask andrask commented Dec 5, 2024 •
edited
Loading

Fixes #1314

@andrask andrask changed the title Concretize Files.Glob documentation (#1314) Concretize Files.Glob documentation Dec 6, 2024
@karenhchu karenhchu added the docs label Jan 14, 2025
TerryHowe
TerryHowe reviewed Mar 9, 2025
View reviewed changes
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going, but think the examples could use more explanation.

I am not a maintainer.

content/en/docs/chart_template_guide/accessing_files.md Outdated
{{- with $currentScope}}
{{ .Files.Get $path }}
{{- end }}
{{ range $path, $content := .Files.Glob "**.yaml" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe have this example actually use the $path or $_ it.

@andrask andrask force-pushed the docs/fix-1314 branch 2 times, most recently from a9fa292 to b9498d3 Compare March 9, 2025 14:29
@andrask
Copy link
Author

andrask commented Mar 9, 2025

@karenhchu or other maintainers: may I ask a review, please! Thank you!

TerryHowe
TerryHowe approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files.Glob documentation unclear
4 participants
@andrask @TerryHowe @karenhchu @andraskoevi