Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed code which causes Godot 3 to report memory leaks (#57) #200

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

puzzud
Copy link

@puzzud puzzud commented Feb 29, 2024

Godot 3 does not support classes referencing their own class type inside their own functions. Using the is keyword in combination will throw a parser error. But using the as keyword similarly does not. Its apparent downstream affect is at least reports of memory leaks.

I have tagged #57 in an associated Godot repo issue and appealed for a Godot maintainer to target Godot 3.6 as it was targeted to Godot 3.5, proposing a solution to guard against this usage of as, as it's unlikely to receive the circular dependency enhancement that Godot 4 received--this nakama-godot issue does not reproduce with Godot 4.

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@lugehorsam lugehorsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @puzzud 👍

@lugehorsam lugehorsam merged commit 2ee6e76 into heroiclabs:godot-3 Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants