Removed code which causes Godot 3 to report memory leaks (#57) #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot 3 does not support classes referencing their own class type inside their own functions. Using the
is
keyword in combination will throw a parser error. But using theas
keyword similarly does not. Its apparent downstream affect is at least reports of memory leaks.I have tagged #57 in an associated Godot repo issue and appealed for a Godot maintainer to target Godot 3.6 as it was targeted to Godot 3.5, proposing a solution to guard against this usage of
as
, as it's unlikely to receive the circular dependency enhancement that Godot 4 received--this nakama-godot issue does not reproduce with Godot 4.