Update default Ruby version to 3.3.7 #1534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/default-ruby-336
branch
2 times, most recently
from
bc8afc7 to
8ca07fc
Compare
The latest Ruby is now 3.4.x. Our ideal default policy is to use the latest release of the prior year's version. This PR updates to the latest Ruby 3.3.x version which is 3.3.6.
|
@schneems could now default to 3.3.7 https://www.ruby-lang.org/en/news/2025/01/15/ruby-3-3-7-released/ |
schneems
force-pushed
the
schneems/default-ruby-336
branch
from
8ca07fc to
9848194
Compare
schneems
changed the title
Fixes:
```
-----> Building on the Heroku-24 stack
-----> Fetching https://github.com/heroku/heroku-buildpack-ruby#schneems/default-ruby-336 buildpack...
buildpack downloaded
-----> Ruby app detected
!
! undefined method `exists?' for class Dir
!
/tmp/buildpacks/55030ecaa578151bf5924184e8750b99212faef5/lib/language_pack/helpers/bundler_wrapper.rb:242:in `fetch_bundler': undefined method `exists?' for class Dir (NoMethodError)
return true if Dir.exists?(bundler_path)
^^^^^^^^
Did you mean? exist?
```
schneems
force-pushed
the
schneems/default-ruby-336
branch
from
72886a1 to
43f05b6
Compare
Bundler 1.x is not able to run with Ruby 3.3 in some circumstances:
```
remote: ! There was an error parsing your Gemfile, we cannot continue
remote: ! /tmp/d20250127-138-l8vq2r/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:29:in `root': undefined method `untaint' for an instance of Pathname (NoMethodError)
remote: !
remote: ! Pathname.new(gemfile).untaint.expand_path.parent
```
This commit updates the default bundler version to 2.3.x.
This asserts that we ignore invalid or incorrect patch numbers i.e. p0 in the gem file.lock is not correct: ``` RUBY VERSION ruby 2.5.1p0 ``` We don't really need to keep and maintain this fixture.
schneems
force-pushed
the
schneems/default-ruby-336
branch
from
4a7d509 to
9356404
Compare
This no longer builds on the platform:
```
remote: ! There was an error parsing your Gemfile, we cannot continue
remote: ! /tmp/d20250204-129-9ld2nw/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:29:in `root': undefined method `untaint' for an instance of Pathname (NoMethodError)
remote: !
remote: ! Pathname.new(gemfile).untaint.expand_path.parent
remote: ! ^^^^^^^^
remote: ! from /tmp/d20250204-129-9ld2nw/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler.rb:234:in `root'
remote: ! from /tmp/d20250204-129-9ld2nw/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler.rb:246:in `app_config_path'
```
…e will find out one way or another).
schneems
force-pushed
the
schneems/default-ruby-336
branch
from
081e6b6 to
c05a1b5
Compare
In Rails 7 the tasks converged into one
schneems
force-pushed
the
schneems/default-ruby-336
branch
from
34cbc47 to
2a0eb3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Ruby is now 3.4.x. Our ideal default policy is to use the latest release of the prior year's version. This PR updates to the latest Ruby 3.3.x version which is 3.3.7.