Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hibernate ORM to 7.0.0.Beta3 #2028

Merged
merged 16 commits into from
Dec 13, 2024
Merged

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Dec 12, 2024

Fix #1826
Fix #1895
Fix #2030
Fix #2032

Notes:

This is a draft because I need to fix the build for the different WIP branches

@DavideD DavideD force-pushed the 1895-ORM-7 branch 11 times, most recently from 8711d5f to 724037b Compare December 13, 2024 09:12
@DavideD DavideD marked this pull request as ready for review December 13, 2024 15:10
Notes:

* Fix hibernate#1826: ReactiveIdentifierGenerator must extends Generator
* The Hibernate Gradle plugin has not been released yet, so we keep it to 7.0.0.Beta2
* XML sql data type is not supported: eclipse-vertx/vertx-sql-client#1475
* Stop using `org.hibernate.dialect.DialectDelegateWrapper` (not
  required anymore)
* Remove `ReactiveOracleSqlAstTranslator` (not required anymore)
* Only process parameters for native queries. See hibernate#2012
* Remove `ReactiveIdentifierGeneratorFactory`: the service doesn't exist
  anymore in ORM
* Add `persist(String, Object)` to the session
* Remove test for `hibernate.create_empty_composites.enabled`: see [HHH-18222](https://hibernate.atlassian.net/browse/HHH-18222)
* Contains some clean ups
* There are still some issues with embeddable mapped as JSON and native queries: See hibernate#1999
else {
boolean veto = false;
final PreInsertEvent event = new PreInsertEvent( entity, id, state, persister, null );
for ( PreInsertEventListener listener : fastSessionServices.eventListenerGroup_PRE_INSERT.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.
private void firePostInsert(Object entity, Object id, Object[] state, EntityPersister persister) {
if ( !fastSessionServices.eventListenerGroup_POST_INSERT.isEmpty() ) {
final PostInsertEvent event = new PostInsertEvent( entity, id, state, persister, null );
for ( PostInsertEventListener listener : fastSessionServices.eventListenerGroup_POST_INSERT.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.
public class ReactiveJsonArrayJdbcTypeConstructor implements JdbcTypeConstructor {
public static final ReactiveJsonArrayJdbcTypeConstructor INSTANCE = new ReactiveJsonArrayJdbcTypeConstructor();

public JdbcType resolveType(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
JdbcTypeConstructor.resolveType
; it is advisable to add an Override annotation.
return resolveType( typeConfiguration, dialect, elementType.getJdbcType(), columnTypeInformation );
}

public JdbcType resolveType(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
JdbcTypeConstructor.resolveType
; it is advisable to add an Override annotation.
public void configure(Type type, Properties params, ServiceRegistry serviceRegistry) {
current = Integer.parseInt( params.getProperty( "offset", "0" ) );
public void configure(GeneratorCreationContext creationContext, Properties parameters) throws MappingException {
current = Integer.parseInt( parameters.getProperty( "offset", "0" ) );

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note test

Potential uncaught 'java.lang.NumberFormatException'.
@DavideD DavideD merged commit 6592c3c into hibernate:main Dec 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant