Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/progress page #13

Merged
merged 15 commits into from
Sep 18, 2024
Merged

Feat/progress page #13

merged 15 commits into from
Sep 18, 2024

Conversation

ZimLim
Copy link
Contributor

@ZimLim ZimLim commented Sep 9, 2024

  • used vertical stepper to track user's progress
  • passed, current, and remaining tests indicated with different icons and color
  • inserted component into Transition page between tests
  • Labels of each tests can be changed within the component

@ZimLim ZimLim requested review from wenhwang97 and vpsx September 9, 2024 20:45
@ZimLim ZimLim requested a review from gregfrasco September 11, 2024 15:26
Copy link
Contributor

@wenhwang97 wenhwang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedbacks on the instructions.

src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
@ZimLim ZimLim requested a review from wenhwang97 September 11, 2024 17:31
Copy link
Contributor

@wenhwang97 wenhwang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug on stepper. Details in the comment.

src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
@ZimLim ZimLim closed this Sep 12, 2024
Copy link
Member

@gregfrasco gregfrasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small clean up

src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
@ZimLim ZimLim reopened this Sep 12, 2024
@ZimLim ZimLim requested a review from wenhwang97 September 12, 2024 17:42
Copy link
Contributor

@wenhwang97 wenhwang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues, mostly linting related. I would like to keep everything consistent, so make sure to:

  • Add spaces between double bracket for sx prop and one space after colon, e.g. sx={{ margin: 2, padding: 4 }}
  • Use double quotation

You can also use the Prettier - Code formatter extensions on VScode. It can help you reformat everything on save. I'm using the default setting. You can also configure it for other coding style as well.

src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
src/components/ProgressPage.tsx Outdated Show resolved Hide resolved
@ZimLim ZimLim requested a review from wenhwang97 September 17, 2024 14:52
@wenhwang97 wenhwang97 merged commit 0d225d5 into main Sep 18, 2024
3 checks passed
@wenhwang97 wenhwang97 deleted the feat/progress-page branch September 18, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants