Use urljoin in mxc_to_url to avoid issues with extra slashes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether or not the URL returned from detect_public_endpoint includes a trailing slash varies depending on external factors (what the homeserver operator put in the well-known file, whether the user included a trailing slash on the command line). Use urljoin to avoid an extra slash regardless (the media URL path should not start with `//_matrix/media/`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether or not the URL returned from detect_public_endpoint includes a trailing slash varies depending on external factors (what the homeserver operator put in the well-known file, whether the user included a trailing slash on the command line). Use urljoin to avoid an extra slash regardless (the media URL path should not start with
//_matrix/media/.