Preserve Non-AI Messages in Message Operations #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating tool names, the message operation was dropping non-AI messages. This fix ensures all message types are preserved during message operations, maintaining conversation context and history. - Add test cases to verify message preservation - Update message operation logic to keep non-AI messages
hinthornw
force-pushed
the
main
branch
3 times, most recently
from
dd81484 to
213ef53
Compare
|
@hinthornw Hi! I've submitted this PR to fix a bug where non-AI messages are being dropped during message operations. Would you have time to review this change? I'm happy to provide any additional context or make adjustments if needed. This is my first PR to this repository - please let me know if there are any contribution guidelines I should follow or if you'd like me to make any adjustments to better align with the project's practices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating tool names, the message operation was dropping non-AI messages (like SystemMessage, HumanMessage, and ToolMessage). This PR fixes the issue by ensuring all message types are preserved during message operations, maintaining the complete conversation context and history.
Changes
Testing
Added test cases that verify:
Impact
This change ensures that conversation context is maintained correctly when updating tool names, which is particularly important for maintaining coherent dialogue history in the trustcall system.