Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(29319): Add notification of not writable config #769

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Jan 28, 2025

See https://hivemq.kanbanize.com/ctrl_board/57/cards/29319/details/

The PR adds a notification when the config-writeable capability is NOT defined

Out-of-scope

  • Capabilities MUST be curated in the OpenAPI specs, not replicated on the front end. This will be part of a further ticket
  • The intended usage of the capability has been inverted. The critical aspect worth notifying users about is when the config is NOT writable, triggering error messages (403) at the front end. However, that state is (mis)detected by the capability (config is writable) being not present in the capabilities list. The undefined content could mean not supported but also not found or API to get the capabilities failed. As the logician says: "Absence of Evidence does not mean Evidence of Absence”. This will be fixed in a further update

After

screenshot-localhost_3000-2025_01_28-19_11_03

@vanch3d vanch3d requested a review from sfrehse January 28, 2025 19:01
@vanch3d vanch3d self-assigned this Jan 28, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 28, 2025
Copy link
Contributor

@h2xd h2xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐊

@vanch3d vanch3d force-pushed the feat/29319/config-writeable branch from a3862fa to 39c6fa8 Compare January 29, 2025 10:52
@vanch3d vanch3d merged commit 41ed967 into master Jan 29, 2025
9 of 10 checks passed
@vanch3d vanch3d deleted the feat/29319/config-writeable branch January 29, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants