Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(29918): clear toast before publishing again #774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Jan 30, 2025

See https://hivemq.kanbanize.com/ctrl_board/57/cards/29918/details/

The PR introduces a hack aiming at avoiding duplication ot toast with the same id (with the effect that they cannot be dismissed)

Out-of-scope

  • A better approach will be to disable the "publish" button until the toasts are cleared by a timeout or when the problems flagged up by the error toasts are resolved. The latter solution is implied with the delivery of a "validity report" but requires tighter integration with the REST API request. It might be done in a further ticket
  • The id created for the toasts assumes a single instance (otherwise they face a duplicated key error). A bug is currently preventing resources from generating their own toast so that assumption is still holding. This bug will be fixed in a subsequent ticket.

Before

screenshot-localhost_3000-2025_01_29-14_39_55

After

screenshot-localhost_3000-2025_01_29-13_52_20

@vanch3d vanch3d requested a review from sfrehse January 30, 2025 12:16
@vanch3d vanch3d self-assigned this Jan 30, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 30, 2025
@vanch3d vanch3d added the do not merge Do not merge until this label is removed. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed do not merge Do not merge until this label is removed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant