Skip to content

Commit

Permalink
chore: Changed endpoint status code from 200 OK to 204 NO Content
Browse files Browse the repository at this point in the history
  • Loading branch information
Arnthorny committed Aug 7, 2024
1 parent 50b4974 commit 8e361de
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
11 changes: 3 additions & 8 deletions api/v1/routes/invitations.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from fastapi import APIRouter, Depends, HTTPException, Request
from fastapi import APIRouter, Depends, HTTPException, Request, status
from sqlalchemy.orm import Session
from urllib.parse import urlparse, parse_qs
from api.v1.schemas import invitations
Expand Down Expand Up @@ -45,7 +45,7 @@ async def add_user_to_organization(

return invite.InviteService.add_user_to_organization(invite_id, session)

@invites.delete("/{invite_id}", status_code=200, response_model=success_response)
@invites.delete("/{invite_id}", status_code=status.HTTP_204_NO_CONTENT)
def delete_invite(
invite_id: str,
db: Session = Depends(get_session),
Expand All @@ -57,9 +57,4 @@ def delete_invite(
if not invite_is_deleted:
raise HTTPException(status_code=404, detail="Invalid invitation id")

logging.info(f"Deleted invite. ID: {invite_id}")

return success_response(
status_code=200,
message='Invite deleted successfully',
)
logging.info(f"Deleted invite. ID: {invite_id}")
6 changes: 1 addition & 5 deletions tests/v1/invitation/test_delete_invitation.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ def test_delete_invite_success(self, client):

response = client.delete(DELETE_ENDPOINT)

assert response.status_code == 200
assert response.json()['message'] == "Invite deleted successfully"
assert response.json().get('data') == None
assert response.json()['success'] == True

assert response.status_code == 204

# Invalid invite id
def test_delete_invite_invalid_id(self, client):
Expand Down

0 comments on commit 8e361de

Please sign in to comment.