adding device_tracker.tomato https params #4389
Conversation
|
I'd suggest adding the default values for the optional parameters (port: 80, ssl: false, verify; true) |
|
Sounds good, I'll update the documents & code to match. |
| @@ -23,20 +23,56 @@ To use this device tracker in your installation, add the following to your `conf | |||
| # Example configuration.yaml entry | |||
| device_tracker: | |||
| - platform: tomato | |||
| host: YOUR_ROUTER_IP_ADDRESS | |||
| host: YOUR_ROUTER_IP_ADDRESS_OR_HOSTNAME | |||
| port: YOUR_ROUTER_PORT | |||
There was a problem hiding this comment.
Optional configuration variables should not be in the examples.
We are trying to keep the examples as minimal as possible.
There was a problem hiding this comment.
It might be a good thing to call out that ^^ in the standards documentation since I don't think it mentions optional variables not being part of the examples.
frenck
added
the
new-feature
|
Thanks for cleaning up @GregoryDosh! 🏅 Can be merged as soon as the parent PR gets merged. |
| description: "The port number of your router, e.g. `443`." | ||
| required: false | ||
| type: int | ||
| default: 80/443 (ssl disabled/ssl enabled) |
There was a problem hiding this comment.
@frenck How should the default port param be handled in the case of ssl/non ssl being chosen? Not sure how this should be represented to the users.
There was a problem hiding this comment.
Maybe reference it as "auto detected"?
Of "80/443 (automatically detected)"
|
Parent PR got merged, I will go ahead and merged the docs in as well. |
Description:
Added new configuration parameters for https support in the device_tracker.tomato component.
Pull request in home-assistant (if applicable): home-assistant/core#11566
Checklist:
current. New documentation for platforms/components and features should go tonext.