Fix desktop icons appearing under the panel on startup. #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this._setDesktopIconsMargins is called. Therefore on DING and gtk4-ding, icons slide under the panel. If the panel is repostioned or reset in any way, it behaves correctly. With this change, desktopIconsUsable area is intialized in the constructor. The margins are set to 0 in disable(reset = true); The entire class is destroyed with disable();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, this._desktopIconsUsableArea is not set as it is not initialized before this._setDesktopIconsMargins is called.
Therefore on DING and gtk4-ding, icons slide under the panel.
If the panel is repositioned or reset in any way, it behaves correctly.
With this change, desktopIconsUsablearea is initialized in the constructor.
The margins are set to 0 in disable(reset = true);
The entire class is destroyed with disable();