Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PHP to list of telemetry libraries #278

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat: add PHP to list of telemetry libraries #278

merged 4 commits into from
Sep 25, 2024

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Sep 24, 2024 •
edited
Loading

Which problem is this PR solving?

  • lack of visibility into php library usage

Short description of the changes

  • add PHP instrumentation library prefix
  • fix typo in test for telemetry.instrumentation_name

@JamieDanielson
fix: use const to avoid typo
1618d72
@JamieDanielson
wip: add other languages
59b3304 
... i think this is not testing what we think it is
@JamieDanielson JamieDanielson requested a review from a team as a code owner September 24, 2024 20:04
@JamieDanielson JamieDanielson self-assigned this Sep 24, 2024
@JamieDanielson JamieDanielson added merge at will Reviewer can merge the PR once reviewed. version: bump minor A PR that adds behavior, but is backwards-compatible. labels Sep 24, 2024
MikeGoldsmith
MikeGoldsmith approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I would prefer not to use a const here as it wouldn't catch changes to the key like it would not.

otlp/traces_test.go Outdated Show resolved Hide resolved
@JamieDanielson JamieDanielson merged commit 906d6e1 into main Sep 25, 2024
6 checks passed
@JamieDanielson JamieDanielson deleted the jamie.add-other-langs branch September 25, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
merge at will Reviewer can merge the PR once reviewed. version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieDanielson @MikeGoldsmith