Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): include original request signal in proxy request #3925

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

BarryThePenguin
Copy link
Contributor

This includes the original Request#signal in the RequestInit options use to create the proxy request

Currently Cloudflare doesn't expose the abort event to Workers, but it looks like there is work to implement it, see:

I'm unsure about other platforms..

fixes #3924

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (0c405b9) to head (00e95cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3925   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         168      168           
  Lines       10689    10690    +1     
  Branches     3056     3019   -37     
=======================================
+ Hits         9762     9763    +1     
  Misses        926      926           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usualoma
Copy link
Member

Hi @BarryThePenguin. Thank you. LGTM!

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@BarryThePenguin

Thank you! Merging.

@yusukebe yusukebe merged commit 6ae0213 into honojs:main Feb 17, 2025
16 checks passed
@BarryThePenguin BarryThePenguin deleted the fix/proxy-request-signal branch February 17, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hono/proxy does not preserve request.signal
3 participants