Skip to content

Commit

Permalink
Use include_package_data instead of package_data
Browse files Browse the repository at this point in the history
This allows us to specify the package data once in the Manifest.in
file. Specifcally, the include_package_data will include files
listed as part of the Manifest.in as part of the package if they
reside in the packages directory. This will also help us avoid
issues where some package files are included in the sdist and
not the wheel because the package_data differs from what is
declared in the Manifest.in
  • Loading branch information
kyleknap committed Aug 25, 2022
1 parent 4a698c4 commit 7fb287a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ include requirements.txt
include UPGRADE_PY3.md
recursive-include awscli/examples *.rst *.txt
recursive-include awscli/data *.json
recursive-include awscli/topics *.rst *.json
5 changes: 1 addition & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,7 @@ def find_version(*file_paths):
'bin/aws_completer', 'bin/aws_zsh_completer.sh',
'bin/aws_bash_completer'],
packages=find_packages(exclude=['tests*']),
package_data={'awscli': ['data/*.json', 'examples/*.rst',
'examples/*/*.rst', 'examples/*/*.txt',
'examples/*/*/*.txt', 'examples/*/*/*.rst',
'topics/*.rst', 'topics/*.json']},
include_package_data=True,
install_requires=install_requires,
extras_require={},
license="Apache License 2.0",
Expand Down

0 comments on commit 7fb287a

Please sign in to comment.