Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Void Linux compatibility #109

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Void Linux compatibility #109

merged 3 commits into from
Jun 8, 2020

Conversation

sv0
Copy link
Contributor

@sv0 sv0 commented Jun 7, 2020

What was a problem?

There was a problem running nipe.pl on Void Linux
Void Linux uses runit (a cross-platform Unix init scheme) instead of systemd.

./nipe.pl start
Use of uninitialized value $id_like in pattern match (m//) at lib/Nipe/Utils/Device.pm line 17.
Use of uninitialized value $id_like in pattern match (m//) at lib/Nipe/Utils/Device.pm line 22.
Use of uninitialized value $id_like in pattern match (m//) at lib/Nipe/Utils/Device.pm line 22.
Password:
sudo: systemctl: command not found
iptables v1.8.5 (legacy): owner: Bad value for "--uid-owner" option: "debian-tor"
Try `iptables -h' or 'iptables --help' for more information.
iptables v1.8.5 (legacy): owner: Bad value for "--uid-owner" option: "debian-tor"
Try `iptables -h' or 'iptables --help' for more information.

How this PR fixes the problem?

  • checks if nipe.pl is running on Void Linux in lib/Nipe/Utils/Device.pm
  • use xbps-install to install dependencies(tor, iptables) on Void Linux
  • use sv instead of systemctl on Void Linux

Check lists (check x in [ ] of list items)

  • Test passed (soon)
  • Coding style (indentation, etc)

Additional Comments

  • check if user running nipe.pl is root
  • get rid of sudo all over the code.

sv0 added 3 commits June 7, 2020 13:15
exit with error message otherwise
get rid of 'sudo' in lib/Nipe/* code
@sv0 sv0 changed the title Void Linux compatibiliry Void Linux compatibility Jun 7, 2020
@htrgouvea
Copy link
Owner

Hi @sv0,

This contribution is incredible, I will review it and soon I'll be back with more information!

Thx

@htrgouvea htrgouvea merged commit 57072e0 into htrgouvea:develop Jun 8, 2020
@htrgouvea
Copy link
Owner

Thanks for that contribution! Throughout the week I will do some more tests and then I should submit everything to the master!

I hope to receive more contributions from you in the future!

@htrgouvea
Copy link
Owner

@all-contributors please add @sv0 for code

@allcontributors
Copy link
Contributor

@GouveaHeitor

I've put up a pull request to add @sv0! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants