feat(cfw): add resource CFW alarm configuration #6246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profoundwu
force-pushed
the
feat_cfw_alarm
branch
5 times, most recently
from
58dd36b to
f6d904b
Compare
houpeng80
reviewed
Jan 22, 2025
profoundwu
force-pushed
the
feat_cfw_alarm
branch
2 times, most recently
from
854c589 to
2068665
Compare
|
/lgtm |
docs/resources/cfw_alarm.md
Outdated
| Manages a CFW alarm resource within HuaweiCloud. | ||
| --- | ||
|
|
||
| # huaweicloud_cfw_alarm |
There was a problem hiding this comment.
Suggested change
| # huaweicloud_cfw_alarm | |
| # huaweicloud_cfw_alarm_config |
Comment on lines
226
to
229
| _, err = GetAlarm(deleteAlarmClient, fwInstanceID, alarmType) | ||
| if err != nil { | ||
| return common.CheckDeletedDiag(d, err, "error retrieving CFW alarm") | ||
| } |
There was a problem hiding this comment.
when delete the resource, terraform will call Read func first, so we don't need to check it here
Suggested change
| _, err = GetAlarm(deleteAlarmClient, fwInstanceID, alarmType) | |
| if err != nil { | |
| return common.CheckDeletedDiag(d, err, "error retrieving CFW alarm") | |
| } |
docs/resources/cfw_alarm.md
Outdated
Comment on lines
67
to
68
| + If `alarm_type` is **1**, the value of `severity` can be **0**, **1**, or **2**. | ||
| + If `alarm_type` is **2**, the value of `severity` must be **3**. |
There was a problem hiding this comment.
waht 0, 1, 2, 3 indicate?
| Type: schema.TypeString, | ||
| Required: true, | ||
| Description: `Specifies the alarm URN.`, | ||
| }, |
There was a problem hiding this comment.
missing parameter
"enable_force_new": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{"true", "false"}, false),
Description: utils.SchemaDesc("", utils.SchemaDescInput{Internal: true}),
},
2068665 to
c2db626
Compare
profoundwu
force-pushed
the
feat_cfw_alarm
branch
from
c2db626 to
9e82298
Compare
profoundwu
changed the title
profoundwu
force-pushed
the
feat_cfw_alarm
branch
from
9e82298 to
2d54739
Compare
profoundwu
force-pushed
the
feat_cfw_alarm
branch
from
2d54739 to
057a1b2
Compare
|
/approve |
github-ci-robot
added
the
approved
|
/lgtm |
github-ci-robot
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add resource CFW alarm
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
ab. Related resources (parent resources) not found
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
bb. Related resources (parent resources) not found
