Fixing some silent bugs in Arabic Custom Tasks #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix alghafa prompt function by explicitly determining the list of choices based on task_name. Not all subsets of AlGhafa Native share same columns
Co-authored-by: Clémentine Fourrier <[email protected]>
Fix to `KeyError: 'sol3'` and `TypeError: Doc.__init__() got an unexpected keyword argument 'target_for_fewshot_sorting'`
correct prompt function
|
Hey @alielfilali01 ! Is is this ready for review ? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Yes @NathanHB but apparently i need to fix the checks again 🥲 i always forget that |
|
Hey @NathanHB, the formatting is fixed with pre-commit hooks ! Thank you and sorry for taking too long on this one. I guess we can approve it and the checks should pass now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to correct the implementation of MadinahQA which was populated without context. Correct the metric for AraTrust and Fix a silent bug in AlGhafa task which was incorrectly handling indexes.
Also remove the exams subset from alghafa suite in examples/tasks/OALL-2-Tasks txt file.
Merging this PR will allow the community to replicate the results displayed in OALL-2