Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we fixed issue #573 by propagating the batch size control parameters to
VLLMModelConfig
. For more detailed explanation of their batch size parameters, see vllm-project/vllm#2492.Testing
I ran the following CLI commands to invoke a simple evaluation job. Based on the results, we can see that controlling
max_num_seqs
will determine the batch size at the pre-filling stage, thus impacting the throughput of the model, i.e., 1m4s withmax_num_seqs=256
(which is the default) vs. 3m15s withmax_num_seqs=1
. I'm testing this with an AWS instance ofg6e.xlarge
.Default
BS=1