Fix/best model checkpoint fix #35885
Open
+193
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #35609 (TL;DR
best_model_checkpoint
is being set when the checkpoint may not even exist)best_global_step
that keeps track of the step where we performed evaluation and achieved a new best metric.best_model_checkpoint
from_determine_best_metric
to_save_checkpoint
._save_checkpoint
, check if thebest_model_checkpoint
actually exists, and set it if so.This was a bit trickier than I thought it would be, since the Trainer's saving and evaluation logic are not tightly coupled as would be in the
save_strategy == "best"
scenario.Before submitting
Pull Request section?
to it if that's the case. Trainer sets
state.best_model_checkpoint
even when it doesn't save there; leads to training crash #35609documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr
@SunMarc
@tomaarsen
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.