feat: migration to leveldb #1401
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR migrates user authentication and subscription data from SQLite to LevelDB while maintaining a hybrid approach for other data storage needs.
- Added encryption for sensitive data in LevelDB using new Crypto utility in
src/main/services/hydra-api.ts - Removed UserAuth and UserSubscription entities from TypeORM/SQLite in favor of LevelDB key-value storage
- Modified sign-out process to use LevelDB batch operations while maintaining SQLite transactions for game data
- Added new
levelDatabasePathconstant for LevelDB storage while preserving SQLite paths for hybrid approach - Introduced potential atomicity concerns between LevelDB and SQLite operations in
src/main/events/auth/sign-out.ts
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
20 file(s) reviewed, 14 comment(s)
Edit PR Review Bot Settings | Greptile
src/main/entity/index.ts
Outdated
| export * from "./user-preferences.entity"; | ||
| export * from "./user-subscription.entity"; | ||
| export * from "./game-shop-cache.entity"; | ||
| export * from "./game.entity"; |
There was a problem hiding this comment.
logic: duplicate export of game.entity on line 1 - remove this line
| const auth = await db.get<string, Auth>(levelKeys.auth, { | ||
| valueEncoding: "json", | ||
| }); |
There was a problem hiding this comment.
logic: db.get() can throw - needs try/catch to handle LevelDB errors gracefully
| const payload = jwt.decode( | ||
| Crypto.decrypt(auth.accessToken) | ||
| ) as jwt.JwtPayload; |
There was a problem hiding this comment.
logic: Crypto.decrypt() can throw - needs try/catch to handle decryption failures
There was a problem hiding this comment.
logic: The one-to-one relationship with UserAuth needs to be maintained in the new LevelDB structure to prevent data inconsistency
| const user = await db.get<string, User>(levelKeys.user, { | ||
| valueEncoding: "json", | ||
| }); |
There was a problem hiding this comment.
logic: no error handling for failed db.get() operations - could throw unhandled exceptions
src/main/services/hydra-api.ts
Outdated
| await db | ||
| .get<string, Auth>(levelKeys.auth, { valueEncoding: "json" }) | ||
| .then((auth) => { | ||
| return db.put<string, Auth>( | ||
| levelKeys.auth, | ||
| { | ||
| ...auth, | ||
| accessToken: Crypto.encrypt(accessToken), | ||
| tokenExpirationTimestamp, | ||
| }, | ||
| { valueEncoding: "json" } | ||
| ); | ||
| }); |
There was a problem hiding this comment.
logic: No error handling if db.get() fails before the .then() - could leave auth in inconsistent state. Should use try/catch.
| const result = await db.getMany<string>([levelKeys.auth, levelKeys.user], { | ||
| valueEncoding: "json", | ||
| }); |
There was a problem hiding this comment.
logic: getMany could fail silently here since there's no error handling. Should wrap in try/catch to handle DB errors.
| db.put<string, Auth>( | ||
| levelKeys.auth, | ||
| { | ||
| id: 1, | ||
| accessToken, | ||
| accessToken: Crypto.encrypt(accessToken), | ||
| refreshToken: Crypto.encrypt(refreshToken), | ||
| tokenExpirationTimestamp, | ||
| refreshToken, | ||
| }, | ||
| ["id"] | ||
| { valueEncoding: "json" } | ||
| ); |
There was a problem hiding this comment.
logic: db.put operation could fail but error is not handled. Should await the operation and handle potential errors.
| db.batch([ | ||
| { | ||
| type: "del", | ||
| key: levelKeys.auth, | ||
| }, | ||
| { | ||
| type: "del", | ||
| key: levelKeys.user, | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
logic: batch delete operation could fail but error is not caught. Should wrap in try/catch to handle DB errors.
thegrannychaseroperation
changed the title
|
When submitting this pull request, I confirm the following (please check the boxes):
Ditching SQLite to use LevelDB instead.