Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: didcomm message body parsing and e2e tests for sd-jwt #358

Closed
wants to merge 3 commits into from
Closed

fix: didcomm message body parsing and e2e tests for sd-jwt #358

wants to merge 3 commits into from
+9 −7

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Jan 27, 2025 •
edited
Loading

Description:

  • Fixed the parsing logic of the body field in the DIDComm protocol
  • Fixed the steps in SD_JWT issuance logic (added schemaId)

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk yshyn-iohk requested a review from a team as a code owner January 27, 2025 14:11
@elribonazo elribonazo requested a review from a team January 27, 2025 16:37
@curtis-h
Copy link
Contributor

Closing as invalid.
Actual issue caused by cloud agent changes.

Ticket to align components here: hyperledger/identus#115

@curtis-h curtis-h closed this Jan 31, 2025
@curtis-h curtis-h deleted the fix/compatibility-issues branch February 3, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioPinheiro FabioPinheiro FabioPinheiro left review comments

@elribonazo elribonazo elribonazo left review comments

@shaileshp0110 shaileshp0110 shaileshp0110 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yshyn-iohk @curtis-h @shaileshp0110 @elribonazo @FabioPinheiro