fix: adding backwards compatibility to manage key curve Secp256k1 and… #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
elribonazo
force-pushed
the
feature/368-curve-values
branch
from
2105532 to
81ce220
Compare
|
… secp256k1 but forcing lowercase for newly created ones Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]> Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
…wards compatibility Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
elribonazo
force-pushed
the
feature/368-curve-values
branch
from
1fccb9c to
00d8346
Compare
amagyar-iohk
reviewed
Feb 4, 2025
amagyar-iohk
reviewed
Feb 4, 2025
amagyar-iohk
reviewed
Feb 4, 2025
amagyar-iohk
reviewed
Feb 4, 2025
amagyar-iohk
reviewed
Feb 4, 2025
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
amagyar-iohk
approved these changes
Feb 4, 2025
curtis-h
reviewed
Feb 4, 2025
Comment on lines
+7
to
+10
| export function isCurve(curve: string, curveEnum: Curve): boolean { | ||
| return curve === curveEnum || | ||
| // For backwards compatibility | ||
| curve === 'Secp256k1'; |
There was a problem hiding this comment.
this doesn't look right, I don't think we should have hardcoded conditionals like this.
wouldn't this incorrectly evaluate, ie:
// curve value from somewhere
const crv = "Secp256k1"
if(isCurve(crv, Curve.ED25519)) {
... do something ed25519 related
}
curtis-h
reviewed
Feb 4, 2025
| @@ -188,7 +188,8 @@ export enum Usage { | |||
| UNKNOWN_KEY = "unknownKey", | |||
| } | |||
| export function curveToAlg(curve: string) { | |||
| if (curve === Curve.SECP256K1) { | |||
| // For backwards compatibility | |||
There was a problem hiding this comment.
what is this aiming for backwards compatibility with? I'd expect to see some tests that demonstrate and prove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding backwards compatible key curve Secp256k1 and secp256k1, but forcing from now on to use it in lowercase as stated in the specs.
Checklist: