Handle max path limit on windows for schema names (backport) #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindaugasdirg
requested review from
MichaelBelousov and
ColinKerr
as code owners
mindaugasdirg
changed the title
MichaelBelousov
previously approved these changes
Nov 30, 2023
There was a problem hiding this comment.
approving since typescript change fixes linter issues when using typescript 5.2
We will want to bump our @typescript-eslint version eventually to be able to use new typescript
You may need to add an // eslint-disable-next-line no-deprecation comment to pass tests on some versions... we should consider not linting when doing minor version compatibility tests
MichaelBelousov
approved these changes
Dec 1, 2023
MichaelBelousov
suggested changes
Dec 1, 2023
MichaelBelousov
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR for #130 changes