Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for mismatching peer dependencies #220

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

derbynn
Copy link
Contributor

@derbynn derbynn commented Oct 23, 2024

nick4598
nick4598 previously approved these changes Oct 24, 2024
@nick4598
Copy link
Collaborator

Also were you seeing the error message thrown in your test app without any extra work needed to be done? It just showed up?

@derbynn
Copy link
Contributor Author

derbynn commented Oct 24, 2024

Also were you seeing the error message thrown in your test app without any extra work needed to be done? It just showed up?

Yes the error showed up when the test app was run and I did not do any extra work to set that up

@derbynn derbynn marked this pull request as ready for review October 24, 2024 14:01
@derbynn derbynn requested review from a team as code owners October 24, 2024 14:01
@derbynn derbynn merged commit 00224c3 into main Oct 24, 2024
14 checks passed
@derbynn derbynn deleted the daniel/improve-error-message-for-peer-deps branch October 24, 2024 14:21
nick4598 added a commit that referenced this pull request Nov 20, 2024
- Include dev versions that still satisfy semver
- Address #191

---------

Co-authored-by: Nick Tessier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in packages/transformer/src/transformer.ts, make the error message for mismatching peer dependencies better.
2 participants