-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation guid optimization #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d31f687.
…have been deleted
All checks are now passing. Marked PR as ready for review. |
MichaelBelousov
commented
Apr 16, 2024
…in/imodel-transformer into federation-guid-optimization
MichaelBelousov
commented
Apr 17, 2024
nick4598
approved these changes
Apr 17, 2024
nick4598
added a commit
that referenced
this pull request
Nov 20, 2024
Instead of using External Source Aspects for transformations, keep track of the previously-transformed source changeset id in the version field of only one external source aspect in the target scoping element in the target, and use changeset data to determine if an iModel has been changed when retransforming. This allows us to skip a lot of updates like we did with the External Source Aspect scheme, but without writing a new aspect on transform relation initialization (e.g. branch forking) --------- Co-authored-by: imodeljs-admin <[email protected]> Co-authored-by: Vilius Ruskys <[email protected]> Co-authored-by: Kyrylo Volotovskyi <[email protected]> Co-authored-by: BENTLEY\Kyrylo.Volotovskyi <[email protected]> Co-authored-by: Daniel Rodriguez <[email protected]> Co-authored-by: Daniel Rodriguez <[email protected]> Co-authored-by: nick.tessier <[email protected]> Co-authored-by: Mindaugas Dirginčius <[email protected]> Co-authored-by: Jiarui Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using External Source Aspects for transformations, keep track of the previously-transformed source changeset id in the version field of only one external source aspect in the target scoping element in the target, and use changeset data to determine if an iModel has been changed when retransforming. This allows us to skip a lot of updates like we did with the External Source Aspect scheme, but without writing a new aspect on transform relation initialization (e.g. branch forking)